apple / password-manager-resources

A place for creators and users of password managers to collaborate on resources to make password management better.
MIT License
4.22k stars 454 forks source link

Added amazon.com to change password URL quirks #799

Closed danielleflinn closed 2 months ago

danielleflinn commented 2 months ago

Overall Checklist

for change-password-URLs.json

ghost commented 2 months ago

Stop sending emails

2k.’


From: Samar Sunkaria @.> Sent: Saturday, August 24, 2024 12:37:09 AM To: apple/password-manager-resources @.> Cc: Subscribed @.***> Subject: Re: [apple/password-manager-resources] Added amazon.com to change password URL quirks (PR #799)

@Sameesunkaria approved this pull request.


In quirks/change-password-URLs.jsonhttps://github.com/apple/password-manager-resources/pull/799#discussion_r1729489923:

@@ -20,6 +20,7 @@ "allianz.com.br": "https://www.allianz.com.br/alteracao-de-password-ecliente", "allrecipes.com": "https://www.allrecipes.com/account/profile#/change-password", "alternate.de": "https://www.alternate.de/html/myAccount/account/basicData.html",

Thank you @danielleflinnhttps://github.com/danielleflinn :)

If you'd like, this would be a good opportunity to add the equivalent urls for the rest of the global amazon domains. You can find a list in websites-with-shared-credential-backends.json.

— Reply to this email directly, view it on GitHubhttps://github.com/apple/password-manager-resources/pull/799#pullrequestreview-2258062214, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQDSZO4H7RVEHHCLUPIABCTZS6MPLAVCNFSM6AAAAABM4J6SLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJYGA3DEMRRGQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Sameesunkaria commented 2 months ago

Looks like the domains aren't sorted alphabetically. You can run the ./tools/autoformat-json-files.rb script to re-format the files.

danielleflinn commented 2 months ago

Updated!

Some general project feedback: it seems a bit odd that websites-with-shared-credential-backends.json are not sorted alphabetically while the change-urls are. My first PR I just copied and pasted the order from the other file.

Sameesunkaria commented 2 months ago

Thank you so much for following through with this back and forth @danielleflinn 😅

Some general project feedback: it seems a bit odd that websites-with-shared-credential-backends.json are not sorted alphabetically while the change-urls are. My first PR I just copied and pasted the order from the other file.

I somewhat agree with this. Our current ordering seems to be arbitrary, with the first domain often being the most prominent one. This allows, for example, "wikipedia.org" to be ordered with W instead of M (for "mediawiki.org"), but as you have found out this ordering is inconsistent across files. I don't have a strong opinion here, but if you feel differently, an issue would be an excellent place to start.