search

apple / pfl-research

Simulation framework for accelerating research in Private Federated Learning
http://apple.github.io/pfl-research/
Apache License 2.0
281 stars 27 forks source link

MLXModel.evaluate does not use dataset.iter #87

Open grananqvist opened 1 month ago

grananqvist commented 1 month ago

This was a miss in the initial MLX implementation. Just like how dataset.iter method is used in other models, e.g. https://github.com/apple/pfl-research/blob/develop/pfl/model/pytorch.py#L389, it should also be used for MLXModel: https://github.com/apple/pfl-research/blob/develop/pfl/model/mlx.py#L261

(131046345)