Open grananqvist opened 1 month ago
This was a miss in the initial MLX implementation. Just like how dataset.iter method is used in other models, e.g. https://github.com/apple/pfl-research/blob/develop/pfl/model/pytorch.py#L389, it should also be used for MLXModel: https://github.com/apple/pfl-research/blob/develop/pfl/model/mlx.py#L261
(131046345)
This was a miss in the initial MLX implementation. Just like how dataset.iter method is used in other models, e.g. https://github.com/apple/pfl-research/blob/develop/pfl/model/pytorch.py#L389, it should also be used for MLXModel: https://github.com/apple/pfl-research/blob/develop/pfl/model/mlx.py#L261
(131046345)