enable val_indices feature in user Dataset

apple / pfl-research

Simulation framework for accelerating research in Private Federated Learning

http://apple.github.io/pfl-research/

Apache License 2.0

281 stars 27 forks source link

enable val_indices feature in user Dataset #93

Open grananqvist opened 1 month ago

grananqvist commented 1 month ago

The val_indices argument here https://github.com/apple/pfl-research/blob/develop/pfl/data/dataset.py#L164 is currently not implemented. fix it. The correct behavior should be if val_indices are provided, then split method should split the user dataset into a train and val partition dataset objects according to those indices and not according to the input arguments of split. This is useful if you have static partitions within each individual user.

(115345691)

hardlyhuman commented 1 month ago

Hi @grananqvist I can take up this and implement if no one is working on it currently

grananqvist commented 1 month ago

sure!