Fix globbed read/import bugs

apple / pkl

A configuration as code language with rich validation and tooling.

https://pkl-lang.org

Apache License 2.0

9.85k stars 258 forks source link

Fix globbed read/import bugs #449

Closed translatenix closed 1 month ago

translatenix commented 2 months ago

This PR fixes several bugs related to globbed reads/imports and makes code improvements along the way.

Bug fixes:

Fix caching of globbed reads
- Glob pattern isn't guaranteed to be a constant
- Both glob resolution and ResolvedGlobElement.getPath() depend on the current module URI
Fix ClassCastException when reflecting on globbed import
Avoid creating an unbounded number of Truffle root nodes per globbed read/import

See commit messages for further details.

bioball commented 1 month ago

Hi @translatenix, are you still planning on working on this PR, and the other ones? If not, we'd be happy to take it past the finish line (and credit you, of course)

bioball commented 1 month ago

FYI @translatenix given the lack of activity here, I'll go ahead and update this PR with my comments, and do the same for #455, #378 and #197. Thanks again for your contributions!