apple / pkl

A configuration as code language with rich validation and tooling.
https://pkl-lang.org
Apache License 2.0
9.85k stars 258 forks source link

Remove obsolete Alpine Linux workaround #457

Closed translatenix closed 2 months ago

translatenix commented 2 months ago

According to https://github.com/oracle/graal/issues/3398, the bug necessitating this workaround was fixed in October 2022.

Note: I can't test this, but hopefully CI can.

bioball commented 2 months ago

Let's apply this diff to enable alpine-linux in CI:

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 0c5df6371..d20fa9b4e 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -753,6 +753,9 @@ workflows:
     - gradle-check-jdk21:
         requires:
         - hold
+    - pkl-cli-linux-alpine-amd64-snapshot:
+        requires:
+        - hold
     when:
       matches:
         value: << pipeline.git.branch >>
@@ -761,6 +764,7 @@ workflows:
     jobs:
     - gradle-check-jdk17
     - gradle-check-jdk21
+    - pkl-cli-linux-alpine-amd64-snapshot
     - bench
     - gradle-compatibility
     - pkl-cli-macOS-amd64-snapshot
@@ -772,6 +776,7 @@ workflows:
         requires:
         - gradle-check-jdk17
         - gradle-check-jdk21
+        - pkl-cli-linux-alpine-amd64-snapshot
         - bench
         - gradle-compatibility
         - pkl-cli-macOS-amd64-snapshot
@@ -803,6 +808,12 @@ workflows:
             ignore: /.*/
           tags:
             only: /^v?\d+\.\d+\.\d+$/
+    - pkl-cli-linux-alpine-amd64-snapshot:
+        filters:
+          branches:
+            ignore: /.*/
+          tags:
+            only: /^v?\d+\.\d+\.\d+$/
     - bench:
         filters:
           branches:
@@ -849,6 +860,7 @@ workflows:
         requires:
         - gradle-check-jdk17
         - gradle-check-jdk21
+        - pkl-cli-linux-alpine-amd64-snapshot
         - bench
         - gradle-compatibility
         - pkl-cli-macOS-amd64-release
@@ -893,6 +905,9 @@ workflows:
     - gradle-check-jdk21:
         requires:
         - hold
+    - pkl-cli-linux-alpine-amd64-snapshot:
+        requires:
+        - hold
     - bench:
         requires:
         - hold
translatenix commented 2 months ago

done