Closed translatenix closed 2 months ago
Overall, LGTM... Why does my IntelliJ not warn about lacking / suggest adding final
modifiers to classes?
Why does my IntelliJ not warn about lacking / suggest adding final modifiers to classes?
Unlike the other commits, this one doesn’t address IntelliJ warnings (see commit messages). It fixes gaps in making classes final, a policy that is generally adhered to in the codebase.
You need to fix some formatting problems to get a green build, though.
Fixed by rebasing.
Squashed the "fix IntelliJ warnings" commits.
Fix all IntelliJ warnings in pkl-core production code except for bogus spelling warnings and warnings about unused public methods. I didn't delete any unused public method because it's hard to tell for sure which packages are public APIs.
Changes made:
@Serial
annotation@Nonnull