apple / pkl

A configuration as code language with rich validation and tooling.
https://pkl-lang.org
Apache License 2.0
9.85k stars 258 forks source link

Fix IntelliJ Java warnings, make classes final if possible #458

Closed translatenix closed 2 months ago

translatenix commented 2 months ago

Fix all IntelliJ warnings in pkl-core production code except for bogus spelling warnings and warnings about unused public methods. I didn't delete any unused public method because it's hard to tell for sure which packages are public APIs.

Changes made:

holzensp commented 2 months ago

Overall, LGTM... Why does my IntelliJ not warn about lacking / suggest adding final modifiers to classes?

translatenix commented 2 months ago

Why does my IntelliJ not warn about lacking / suggest adding final modifiers to classes?

Unlike the other commits, this one doesn’t address IntelliJ warnings (see commit messages). It fixes gaps in making classes final, a policy that is generally adhered to in the codebase.

translatenix commented 2 months ago

You need to fix some formatting problems to get a green build, though.

Fixed by rebasing.

translatenix commented 2 months ago

Squashed the "fix IntelliJ warnings" commits.