apple / pkl

A configuration as code language with rich validation and tooling.

https://pkl-lang.org

Apache License 2.0

10.15k stars 270 forks source link

[Fix][CI] Use JDK 17 image for deploy-snapshot job #468

Closed fumiya-kume closed 5 months ago

fumiya-kume commented 5 months ago

Cause

The CI is failing for deploy-snapshot job. Ref: https://app.circleci.com/pipelines/github/apple/pkl/760/workflows/b39c0772-56db-4ba3-a5bc-edef38e25bc2/jobs/4203

The reason is that using image is JDK11.0, but we specify the 17.0

fumiya-kume commented 5 months ago

Thanks! The source of truth of our CI jobs are in Pkl.

Please make the change in .circleci/jobs/DeployJob.pkl, then run pkl eval .circleci/config.pkl -o .circleci/config.yml and commit those changes.

That's make sense 😢 let me fix.

fumiya-kume commented 5 months ago

Thanks! The source of truth of our CI jobs are in Pkl.

Please make the change in .circleci/jobs/DeployJob.pkl, then run pkl eval .circleci/config.pkl -o .circleci/config.yml and commit those changes.

I fixed with update the pkl file. and then generate it.

The tool is quite cool! Thank you for kind supporting for it! 🙇