search

apple / pkl

A configuration as code language with rich validation and tooling.
https://pkl-lang.org
Apache License 2.0
10.38k stars 280 forks source link

Untangle external reader code #776

Open translatenix opened 2 weeks ago

translatenix commented 2 weeks ago

See commit messages for details. Second commit is a pure rename refactoring.

bioball commented 2 weeks ago

Thanks for the PR, and appreciate the help straightening this out!

FYI--this is a little late to get into the 0.27 release. However, we can get this into the main branch once this release is out.

We can also take some time to better look at the API of pkl-core and have a clear definition of what's public and what's not (and perhaps use JPMS).

translatenix commented 2 weeks ago

FYI--this is a little late to get into the 0.27 release.

Just keep in mind that this PR makes breaking changes to APIs introduced in 0.27.

We can also take some time to better look at the API of pkl-core and have a clear definition of what's public and what's not (and perhaps use JPMS).

I'd appreciate this. It will likely take quite a while until pkl-core is ready for JPMS. But we can take one step at a time: define which packages are public, enforce at build time that they don't export private packages, etc.

translatenix commented 2 weeks ago

For the next release, could we create a release branch at least one week before the release, and merge only bugfixes from then on?

bioball commented 2 weeks ago

Yeah, we should definitely add some more process here, including cut-off for features. We'll figure out what that should look like after we get 0.27 out and into the world.

Apologies for the lack of structure right now.