apple / servicetalk

A networking framework that evolves with your application
https://docs.servicetalk.io
Apache License 2.0
926 stars 181 forks source link

Naming inconsistencies for HTTP filters #119

Open NiteshKant opened 6 years ago

NiteshKant commented 6 years ago

HTTP APIs follow the convention:

However, we only provide ways to add async streaming filters, so we drop the qualification in the name. eg: TracingHttpServiceFilter extends StreamingHttpService but it does not have a name qualification according to the above convention. The rational is to reduce naming verbosity at the cost of not following the conventions.

Not following conventions can cause confusion for users and we should revisit to see if we can reduce this confusion.

NiteshKant commented 6 years ago

Some relevant discussion here: https://github.com/servicetalk/servicetalk/pull/112#discussion_r223803835