Flaky Test: ClientEffectiveStrategyTest

apple / servicetalk

A networking framework that evolves with your application

https://docs.servicetalk.io

Apache License 2.0

912 stars 180 forks source link

Flaky Test: ClientEffectiveStrategyTest #2245

Open bondolo opened 2 years ago

bondolo commented 2 years ago

https://github.com/apple/servicetalk/pull/2244/checks?check_run_id=6799736339

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=OFFLOAD_NEVER_STRATEGY LB=OFFLOAD_NEVER_STRATEGY CF=null
java.lang.AssertionError: API=BLOCKING_AGGREGATED, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, apiStrategy=OFFLOAD_EVENT_STRATEGY. Async Errors! See suppressed

java.lang.AssertionError: API=BLOCKING_AGGREGATED, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, apiStrategy=OFFLOAD_EVENT_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:501)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:282)
    at jdk.internal.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
    at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
    at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
    at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:46)
    at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
    at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
    at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestTemplateMethod(TimeoutExtension.java:92)
    at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
    at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
    at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
    at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
    at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
    at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
    at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
    at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
    at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
    at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
    at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
    at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
    at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
    at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
    at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
    at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
    at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
    at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
    at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
    at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
    at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
    at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
    at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send, but was running on an offloading executor thread: client-executor-3-5. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:490)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1940)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:472)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:462)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/pull/2254/checks?check_run_id=6941365663

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NONE_STRATEGY filter=OFFLOAD_NEVER_STRATEGY LB=OFFLOAD_SEND_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-2. clientStrategy=OFFLOAD_NONE_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/runs/7156620156

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=OFFLOAD_NEVER_STRATEGY LB=OFFLOAD_NONE_STRATEGY CF=OFFLOAD_NEVER_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-5. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/runs/7158092150

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=null LB=null CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send, but was running on an offloading executor thread: client-executor-5-2. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1932)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/runs/7158091706

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NEVER_STRATEGY filter=null LB=DEFAULT_HTTP_EXECUTION_STRATEGY CF=OFFLOAD_SEND_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-2. clientStrategy=OFFLOAD_NEVER_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NEVER_STRATEGY filter=OFFLOAD_SEND_STRATEGY LB=OFFLOAD_ALL_STRATEGY CF=OFFLOAD_NEVER_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:337)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-2. clientStrategy=OFFLOAD_NEVER_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/pull/2257/checks?check_run_id=7158336577

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NONE_STRATEGY filter=DEFAULT_HTTP_EXECUTION_STRATEGY LB=OFFLOAD_NEVER_STRATEGY CF=DEFAULT_HTTP_EXECUTION_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send, but was running on an offloading executor thread: client-executor-5-1. clientStrategy=OFFLOAD_NONE_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1908)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=null LB=null CF=OFFLOAD_NEVER_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-4. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)

Scottmitch commented 2 years ago

https://github.com/apple/servicetalk/runs/7815903522 (snapshot build)

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=OFFLOAD_NONE_STRATEGY LB=OFFLOAD_NONE_STRATEGY CF=OFFLOAD_NEVER_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-1. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:263)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)

tkountis commented 2 years ago

ClientEffectiveStrategyTest.Type=MULTI_BUILDER builder=OFFLOAD_ALL_STRATEGY filter=OFFLOAD_NEVER_STRATEGY LB=null CF=OFFLOAD_NEVER_STRATEGY
java.lang.AssertionError: API=BLOCKING_STREAMING, apiStrategy=OFFLOAD_ALL_STRATEGY, clientStrategy=OFFLOAD_ALL_STRATEGY, expectedStrategy=OFFLOAD_ALL_STRATEGY. Async Errors! See suppressed

java.lang.AssertionError: API=BLOCKING_STREAMING, apiStrategy=OFFLOAD_ALL_STRATEGY, clientStrategy=OFFLOAD_ALL_STRATEGY, expectedStrategy=OFFLOAD_ALL_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:337)

https://github.com/apple/servicetalk/pull/2348/checks?check_run_id=8310753563

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2440/checks?check_run_id=9676646223

ClientEffectiveStrategyTest.Type=MULTI_BUILDER builder=null filter=OFFLOAD_NEVER_STRATEGY LB=OFFLOAD_NEVER_STRATEGY CF=OFFLOAD_NONE_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-4. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1940)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2444/checks?check_run_id=9677905936

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=null LB=OFFLOAD_NEVER_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-5. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$null$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

idelpivnitskiy commented 1 year ago

https://github.com/apple/servicetalk/pull/2520/checks?check_run_id=11633533654

ClientEffectiveStrategyTest.Type=MULTI_BUILDER builder=null filter=OFFLOAD_NEVER_STRATEGY LB=OFFLOAD_NONE_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)
    at jdk.internal.reflect.GeneratedMethodAccessor42.invoke(Unknown Source)
    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send, but was running on an offloading executor thread: client-executor-5-1. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1908)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2555/checks?check_run_id=12913256561

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_ALL_STRATEGY filter=OFFLOAD_NEVER_STRATEGY LB=DEFAULT_HTTP_EXECUTION_STRATEGY CF=DEFAULT_HTTP_EXECUTION_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_ALL_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)
    at jdk.internal.reflect.GeneratedMethodAccessor46.invoke(Unknown Source)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-3. clientStrategy=OFFLOAD_ALL_STRATEGY, expectedStrategy=OFFLOAD_ALL_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)

idelpivnitskiy commented 1 year ago

https://github.com/apple/servicetalk/pull/2614/checks?check_run_id=13905833089

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NONE_STRATEGY filter=DEFAULT_HTTP_EXECUTION_STRATEGY LB=OFFLOAD_SEND_STRATEGY CF=OFFLOAD_ALL_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
...
    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-5. clientStrategy=OFFLOAD_NONE_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1940)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:112)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base/java.lang.Thread.run(Thread.java:1623)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2640/checks?check_run_id=14783343570

ClientEffectiveStrategyTest.Type=MULTI_BUILDER builder=null filter=null LB=null CF=OFFLOAD_NEVER_STRATEGY
java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:337)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-5-2. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:116)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/runs/16047242078

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=OFFLOAD_NONE_STRATEGY LB=OFFLOAD_NONE_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-7-4. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1940)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:117)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2678/checks?check_run_id=16074782218

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=null LB=OFFLOAD_NEVER_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-7-5. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:117)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2684/checks?check_run_id=16351475169

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=null LB=OFFLOAD_NEVER_STRATEGY CF=OFFLOAD_NONE_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-7-3. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:117)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 year ago

https://github.com/apple/servicetalk/pull/2690/checks?check_run_id=16697253580

ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NONE_STRATEGY filter=null LB=DEFAULT_HTTP_EXECUTION_STRATEGY CF=null

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)

    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send, but was running on an offloading executor thread: client-executor-7-5. clientStrategy=OFFLOAD_NONE_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=OFFLOAD_ALL_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1932)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:117)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

bryce-anderson commented 11 months ago

https://github.com/apple/servicetalk/pull/2737/checks?check_run_id=18060199944 Essentially identical as the last.

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=OFFLOAD_NONE_STRATEGY LB=null CF=OFFLOAD_NEVER_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:337)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
...

Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-7-3. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)

daschl commented 11 months ago

@bryce-anderson thanks - good to understand that the last flaky test fixes did not help with this. looking.

bryce-anderson commented 9 months ago

Another failure https://github.com/apple/servicetalk/actions/runs/7008105255/job/19063661335#step:7:1036

ClientEffectiveStrategyTest > clientStrategy(BuilderType, HttpExecutionStrategy, HttpExecutionStrategy, HttpExecutionStrategy, HttpExecutionStrategy) > Type=SINGLE_BUILDER builder=OFFLOAD_SEND_STRATEGY filter=null LB=OFFLOAD_ALL_STRATEGY CF=OFFLOAD_NEVER_STRATEGY FAILED
    java.lang.AssertionError: API=ASYNC_STREAMING, apiStrategy=OFFLOAD_ALL_STRATEGY, clientStrategy=OFFLOAD_ALL_STRATEGY, expectedStrategy=OFFLOAD_ALL_STRATEGY. Async Errors! See suppressed
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:337)

The output didn't seem to contain a suppressed exception.

Scottmitch commented 9 months ago

https://github.com/apple/servicetalk/pull/2769/checks?check_run_id=19163365328

ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=null LB=OFFLOAD_NONE_STRATEGY CF=OFFLOAD_NONE_STRATEGY

java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
    at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562)
    at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328)
...
    Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send, but was running on an offloading executor thread: client-executor-7-5. clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY, requestStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.lambda$recordThread$0(ClientEffectiveStrategyTest.java:550)
        at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1940)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.recordThread(ClientEffectiveStrategyTest.java:532)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder$1.lambda$request$0(ClientEffectiveStrategyTest.java:522)
        at io.servicetalk.concurrent.api.PublisherDoOnUtils$5.request(PublisherDoOnUtils.java:141)
        at io.servicetalk.concurrent.api.WhenSubscriptionPublisher$DoSubscriptionPublisherSubscriber$BeforeSubscription.request(WhenSubscriptionPublisher.java:83)
        at io.servicetalk.concurrent.api.ContextPreservingSubscription.request(ContextPreservingSubscription.java:48)
        at io.servicetalk.concurrent.internal.DelayedSubscription.request(DelayedSubscription.java:77)
        at io.servicetalk.concurrent.api.DelayedCancellableThenSubscription.request(DelayedCancellableThenSubscription.java:46)
        at io.servicetalk.concurrent.api.SingleConcatWithPublisher$ConcatDeferNextSubscriber.request(SingleConcatWithPublisher.java:366)
        at io.servicetalk.concurrent.api.ScanWithPublisher$ScanWithSubscriber$1.request(ScanWithPublisher.java:117)
        at io.servicetalk.concurrent.api.TaskBasedAsyncPublisherOperator$OffloadedSubscription.executeTask(TaskBasedAsyncPublisherOperator.java:436)
        at io.servicetalk.concurrent.api.ContextPreservingRunnable.run(ContextPreservingRunnable.java:46)

Scottmitch commented 1 day ago

https://github.com/apple/servicetalk/actions/runs/10959243976/job/30431175672?pr=3061#step:8:1437

> Task :servicetalk-http-netty:test

ClientEffectiveStrategyTest > clientStrategy(BuilderType, HttpExecutionStrategy, HttpExecutionStrategy, HttpExecutionStrategy, HttpExecutionStrategy) > Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=null filter=OFFLOAD_NONE_STRATEGY LB=null CF=OFFLOAD_NEVER_STRATEGY FAILED
    java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:566)
        at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:331)