apple / servicetalk

A networking framework that evolves with your application
https://docs.servicetalk.io
Apache License 2.0
915 stars 180 forks source link

Set `SslContextBuilder.endpointIdentificationAlgorithm` for Netty 4.2.x #2985

Closed idelpivnitskiy closed 3 months ago

idelpivnitskiy commented 3 months ago

Motivation:

In version 4.2.x, Netty introduced new API SslContextBuilder.endpointIdentificationAlgorithm(String) and flipped the default value to HTTPS.

Modifications:

Result:

Hostname verification algorithm is enabled/disabled as expected for ST users with Netty 4.2.x in the classpath.

idelpivnitskiy commented 3 months ago

Correct, I left that intentionally as a fallback for Netty 4.1.x