apple / servicetalk

A networking framework that evolves with your application
https://docs.servicetalk.io
Apache License 2.0
927 stars 181 forks source link

`TcpServerBinder`: don't log "Failed to create a connection" twice #3113

Closed idelpivnitskiy closed 1 week ago

idelpivnitskiy commented 1 week ago

Motivation:

TcpServerBinder uses beforeOnError to log any failures to create a connection (to capture connection info) and then it goes to SimpleSingleSubscriber that logs it again.

Modifications:

Result:

Exception is logged only once.