search

apple / swift-argument-parser

Straightforward, type-safe argument parsing for Swift
Apache License 2.0
3.3k stars 311 forks source link

build: correct ordering of `include` #608

Closed compnerd closed 8 months ago

compnerd commented 8 months ago

Correct the ordering that @bnbarham pointed out post-commit. Ensure that we adjust the CMAKE_MODULE_PATH prior to the use of include which will reference local modules.

compnerd commented 8 months ago

@rauhul - turns out that I do not have commit access on the repository, I would appreciate it if you could assist with that as well 😀

CC: @bnbarham @xedin

compnerd commented 8 months ago

@swift-ci please test

rauhul commented 8 months ago

@rauhul - turns out that I do not have commit access on the repository, I would appreciate it if you could assist with that as well 😀

CC: @bnbarham @xedin

Hmm I don't have the ability to fix that and I don't think Nate can either; I think either @shahmishal or @tkremenek would need change the repo permissions.

In the interim I am happy to press merge on your behalf 😅

natecook1000 commented 8 months ago

LGTM! @compnerd will this require a new release?

compnerd commented 8 months ago

@natecook1000 - I don't think that the previous change went into 1.3.0, so I think we should be okay. If it did make it into 1.3.0, we should do a 1.3.1.

compnerd commented 8 months ago

@natecook1000, @rauhul - anything else to do before we can merge this?

natecook1000 commented 8 months ago

Nope! Thanks @compnerd!