Open dabrahams opened 4 months ago
@swift-ci please test
Yeah, I'd prefer to keep the logging. If they aren't a WARNING
, and aren't an ERROR
, they won't prevent you from continuing and are just informational, but if they aren't emitted and you were expecting to find them, having that in the log is definitely preferable to scratching your head wondering why things were getting built weirdly.
Maybe instead of marking these QUIET
, we could add an additional message that contextualizes the output?
Maybe you could conditionally find_package
based on the conditions that actually require them, and under those conditions make them REQUIRED
? The current situation:
XCTest
actually is found, only later. So it's not just alarming, it's misleading to see this message.
These packages are not marked
REQUIRED
and when this project is used as a dependency of another CMake project they don't need to be findable when this CMakeLists.txt is read. They may in fact be found later in the configuration process, so the messages when they actually are needed, so the messagesare needlessly alarming.
Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.
Checklist