search

apple / swift-argument-parser

Straightforward, type-safe argument parsing for Swift
Apache License 2.0
3.3k stars 311 forks source link

Import new Android overlay #651

Closed finagolfin closed 1 month ago

finagolfin commented 1 month ago

This new overlay was recently added to trunk in swiftlang/swift#72161 and swiftlang/swift#72634, then to 6.0 in swiftlang/swift#74758. I've been building it with this patch on my daily Android CI since the trunk addition, finagolfin/swift-android-sdk#151, and natively on Android too.

@natecook1000, an easy review.

rauhul commented 1 month ago

@swift-ci test

finagolfin commented 1 month ago

I will check if Bionic can be used here instead and let you know.

finagolfin commented 1 month ago

Alright, I checked and symbols imported in this file, like STDOUT_FILENO from unistd.h, are not available from the Bionic module that Swift uses, so this pull is ready for merging.

finagolfin commented 1 month ago

@natecook1000, ready for merge.

finagolfin commented 1 month ago

Rebased and fixed the merge conflict, one more CI run and this can go in.

rauhul commented 1 month ago

@swift-ci test