make AsyncRemoveDuplicatesSequence's init public

apple / swift-async-algorithms

Async Algorithms for Swift

Apache License 2.0

2.95k stars 147 forks source link

make AsyncRemoveDuplicatesSequence's init public #291

Open yermukhanbet opened 1 year ago

yermukhanbet commented 1 year ago

Currently our team is using removeDuplicates() function for the AsyncPublisher in one of our service protocols as a return type. Since for each service we have both live and mock structs, I faced an issue with mocking ASyncRemoveDuplicatesSequence value, as the init is internal.

In this PR I changed it to public. Please, let me know if internal init was intentional approach, so I will try to find another possible way for mocking the return type.

FranzBusch commented 1 year ago

Right now this is intentional. We might want to revisit this on a larger scale if we do it and make all inits public. cc @phausler