Mark managed atomic constructs Sendable if their payloads are

apple / swift-atomics

Low-level atomic operations for Swift

Apache License 2.0

1.08k stars 52 forks source link

Mark managed atomic constructs Sendable if their payloads are #46

Closed lorentey closed 1 year ago

lorentey commented 3 years ago

Resolves #45.

Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've verified that my change does not break any existing tests.
[ ] I've updated the documentation if necessary.

lorentey commented 3 years ago

@swift-ci test

lorentey commented 3 years ago

17:36:08 
/Users/buildnode/jenkins/workspace/pr-swift-atomics-macos/branch-main/swift-atomics/Sources/Atomics/autogenerated/HighLevelTypes.swift:105:26: error: unknown attribute 'unchecked'
17:36:08 extension ManagedAtomic: @unchecked Sendable where Value: Sendable {}
17:36:08                          ^
17:36:08 /Users/buildnode/jenkins/workspace/pr-swift-atomics-macos/branch-main/swift-atomics/Sources/Atomics/autogenerated/HighLevelTypes.swift:82:14: error: non-final class 'ManagedAtomic' cannot conform to `Sendable`; use `UnsafeSendable`
17:36:08 public class ManagedAtomic<Value: AtomicValue> {
17:36:08              ^

ಠ_ಠ

lorentey commented 3 years ago

@swift-ci test

lorentey commented 3 years ago

@swift-ci test macOS platform

lorentey commented 3 years ago

@swift-ci test

lorentey commented 3 years ago

@swift-ci test

lorentey commented 2 years ago

@swift-ci test

jpsim commented 2 years ago

It'd be great to land this so consumers don't need to @preconcurrency import Atomics.

weissi commented 1 year ago

It'd be great to land this so consumers don't need to @preconcurrency import Atomics.

lorentey commented 1 year ago

@swift-ci test