apple / swift-cassandra-client

Cassandra client in Swift
https://swiftpackageindex.com/apple/swift-cassandra-client/main/documentation/cassandraclient
Apache License 2.0
94 stars 21 forks source link

Make Statement.setPagingSize method public #30

Open virtan opened 5 months ago

virtan commented 5 months ago

Make Statement.setPagingSize method public

Motivation:

In some cases we may need to change paging size to reduce chances of read timeouts

Modifications:

The method setPagingSize() existed but wasn't public so was inaccessible for clients

Result:

With this change it would become public and let a client to set custom paging sizes on per statement basis

virtan commented 5 months ago

There is a variant of execute() method which also expects pageSize in Int32. It is public already, so changing it may introduce some backward compatibility issues.

glbrntt commented 5 months ago

There is a variant of execute() method which also expects pageSize in Int32. It is public already, so changing it may introduce some backward compatibility issues.

That one should ideally be Int too, we can separately deprecate that variant of execute and add one using Int.

I'd much rather we course correct and add appropriate APIs rather than being consistent with past mistakes.