search

apple / swift-cluster-membership

Distributed Membership Protocol implementations in Swift
https://apple.github.io/swift-cluster-membership/
Apache License 2.0
201 stars 20 forks source link

Reduce the namespacing nesting in SWIM? #13

Closed ktoso closed 4 years ago

ktoso commented 4 years ago

We're nesting a bit too much, and types end up looking like:

SWIM.SWIM.Member(..., status: SWIM.SWIM.Status.unreachable(incarnation: 0), protocolPeriod: 1, suspicionStartedAt:

we can skip the SWIM namespace enum I believe.

ktoso commented 4 years ago

Not really sure about it tbh, the namespacing reads good with SWIMInstance etc after all, and prefixing will add the same amount of repetition; so seems it may not raelly matter

ktoso commented 4 years ago

I actually think we look good now.

Screen Shot 2020-08-26 at 23 25 11