search

apple / swift-cluster-membership

Distributed Membership Protocol implementations in Swift
https://apple.github.io/swift-cluster-membership/
Apache License 2.0
201 stars 20 forks source link

Node is not an SWIMAddressablePeer, just peers are; pass peers everywhere #25

Closed ktoso closed 4 years ago

ktoso commented 4 years ago

This vastly improves how we think about peers.

When we decode we need to ensure we get a channel to create a peer, but that's simple enough via userInfo.

This removes the weird conformance of Node to SWIMAddressablePeer and just uses peers everywhere, which is more consistent and composable.

ktoso commented 4 years ago

Something is weird, CI passed but it does not report back? https://ci.swiftserver.group/job/swift-cluster-membership-sanity-pr1b/29/

ktoso commented 4 years ago

Ah it just was slow to update