search

apple / swift-cluster-membership

Distributed Membership Protocol implementations in Swift
https://apple.github.io/swift-cluster-membership/
Apache License 2.0
201 stars 20 forks source link

[WIP] Instrument the instance and shell using Swift Metrics #56

Closed ktoso closed 4 years ago

ktoso commented 4 years ago

Motivation:

SWIM is a great example of a very internal piece of clusters which should expose metrics well.

And there's all kinds of types of metrics, gauges for the membership, counters for total messages etc, and recorders for how many data we sent etc.

In this PR trying to explore the best patterns for instrumenting such middleware with swift-metrics.

Modifications:

Still work in progress

Result:

tomerd commented 4 years ago

this is pretty cool 👍 why still in draft?

ktoso commented 4 years ago

why still in draft?

Not complete :) Not all metrics are called yet, I'll finish it up soon enough though.

ktoso commented 4 years ago

Something weird happened here:

Screen Shot 2020-09-17 at 23 15 07

making a new PR

ktoso commented 4 years ago

Replaced by https://github.com/apple/swift-cluster-membership/pull/70