search

apple / swift-cluster-membership

Distributed Membership Protocol implementations in Swift
https://apple.github.io/swift-cluster-membership/
Apache License 2.0
201 stars 20 forks source link

Use Swift 5.2.5 in 5.2 docker because Codable fixes #57

Closed ktoso closed 4 years ago

ktoso commented 4 years ago

We use top level encoders in tests and it would be nice to use the 5.2.5 swift in docker so we don't have to reintroduce the workarounds for 2.5.4.

CI is on 5.2.5 so that's good -- just about the

docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.1804.53.yaml run test to also pass.

5.3 is fine.

tomerd commented 4 years ago

the CI system will pull the latest 5.2 so that should work OOTB? or are you referring to local instructions?

ktoso commented 4 years ago

Ah I just realized what had happened.

I locally had a docker image from before 5.2.5 was released and it simply kept using that... Silly me, we're good here 👍