search

apple / swift-cluster-membership

Distributed Membership Protocol implementations in Swift
https://apple.github.io/swift-cluster-membership/
Apache License 2.0
201 stars 20 forks source link

=metrics more precise emitting of pingRequest metrics #73

Closed ktoso closed 4 years ago

ktoso commented 4 years ago

Be more precise about where we emit the pingRequestResponseTimeFirst metric -- it was wrongly being called before the "first" future rather than inside it -- guaranteeing only the single emission of this metric.

ktoso commented 4 years ago

Fairly hard to make a test for this to be honest... ~going to cut a patch release for now as it's only a change in the example impl.~

ktoso commented 4 years ago

Oh actually, no need for release since it's just in the NIO example shell :)