apple / swift-collections-benchmark

A benchmarking tool for Swift Collection algorithms
Apache License 2.0
346 stars 23 forks source link

Make Paths Windows‐Compatible #9

Closed SDGGiesbrecht closed 3 years ago

SDGGiesbrecht commented 3 years ago

This resolves swift‐collections‐benchmark’s portion of apple/swift-collections#33.

Checklist

SDGGiesbrecht commented 3 years ago

These file names were generated by the tool itself, based on the corresponding library definition, which has been updated to use - instead of :, and we should use the same names here.

L.O.L. I was trying to work on the dependency graph from the bottom up (swift-collections-benchmarks before swift-collections), but I guess I was holding it backwards. With the original definitions changed, will all the derived stuff in this repository be automatically fixed by the next run? If so, then I recommend just doing that and scrapping this PR. This was done by hand not realizing root definitions existed elsewhere.

lorentey commented 3 years ago

Oh, these won't be automatically regenerated -- synchronizing the filenames will just make things easier if these examples ever need to be recreated.

SDGGiesbrecht commented 3 years ago

I addressed the feedback about existing changes.

To prevent similar issues when people try to run benchmarks on Windows, it would be a good idea to make sure the tool filters out invalid characters from the filenames it generates.

I would rather leave that for someone more familiar with the Windows than I am. It does not appear that simple: https://stackoverflow.com/a/1976050/5280938

lorentey commented 3 years ago

@swift-ci test

lorentey commented 3 years ago

I submitted #10 to fix generated filenames on Windows.