search

apple / swift-corelibs-foundation

The Foundation Project, providing core utilities, internationalization, and OS independence
swift.org
Apache License 2.0
5.23k stars 1.12k forks source link

Remove URL in favor of swift-foundation's URL #4955

Closed jmschonfeld closed 1 month ago

jmschonfeld commented 1 month ago

This PR removes the URL type in favor of the URL type provided by swift-foundation. It contains a few minor test adjustments to account for the new URL parser (which can behave slightly differently).

This disables one test which we'll come back to soon to update for the new parsing behavior (cc @jrflat), otherwise all but 2 tests pass and those two failures will be fixed by https://github.com/apple/swift-foundation/pull/602 which contains a bug-fix for URLs created from relative paths. I'll update the dependency's commit hash once that PR is merged

jmschonfeld commented 1 month ago

The latest commit updates the swift-foundation dependency to the commit that resolves the two test failures. Now all tests pass on linux with this change (aside from the one test that is disabled)