apple / swift-corelibs-libdispatch

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware
swift.org
Apache License 2.0
2.46k stars 459 forks source link

Add more comments for #endif in .h file. #839

Closed lamtrinhdev closed 1 month ago

lamtrinhdev commented 2 months ago

This is a long .h file. I would like to are more comment for #endif.

lamtrinhdev commented 2 months ago

Dear @rokhinip ,

Base on the old PR https://github.com/apple/swift-corelibs-libdispatch/pull/837 , I moved the the new PR with single commit. Please help me to review it.

Thanks, Lam

rokhinip commented 2 months ago

Please kick off CI and then merge it.

lamtrinhdev commented 2 months ago

@swift-ci please test

lamtrinhdev commented 2 months ago

Dear @rokhinip ,

I do not have permission to call @swift-ci and merge. Could you please support me?

Thanks, Lam

rokhinip commented 2 months ago

I can do that but we need to get you access if you are planning to continue contributing because I cannot be doing this for every PR you put up

rokhinip commented 2 months ago

@swift-ci please test

lamtrinhdev commented 2 months ago

Dear @rokhinip ,

I got it. Thank you for your support.

Thanks, Lam

lamtrinhdev commented 1 month ago

Dear @rokhinip ,

Could you help me to merge the PR?

Thanks, Lam