-testkit remove the Task.select based timeout impl, make a group based one

apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors

https://apple.github.io/swift-distributed-actors/

Apache License 2.0

580 stars 54 forks source link

-testkit remove the Task.select based timeout impl, make a group based one #1109

Closed ktoso closed 1 year ago

ktoso commented 1 year ago

Main is broken right now, this unbreaks it.

We were depending on a work in progress async-algorithms and Task.select was removed without replacement.

We only used this in testing though, so I reimplemented it as a task group based one. It's not quite the same, but consensus is that such impl is "more correct"

resolves https://github.com/apple/swift-distributed-actors/issues/1108

ktoso commented 1 year ago

5.8 CI is not set up, this will let us confirm if 5.8 is passing in the other PR.

ktoso commented 1 year ago

This is to unblock you @weissi