search

apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors
https://apple.github.io/swift-distributed-actors/
Apache License 2.0
587 stars 55 forks source link

Distributed singleton should be more careful with handover #1127

Closed ktoso closed 1 year ago

ktoso commented 1 year ago

Don't review yet;

Resolves https://github.com/apple/swift-distributed-actors/issues/1123 by hardedning how the redirecring is done. This is still not optimal but hit IRGen issue

ktoso commented 1 year ago

Once again a different flaky one: https://github.com/apple/swift-distributed-actors/issues/1124 And https://github.com/apple/swift-distributed-actors/issues/1128 -- this seems new but also only in one of the runs, so adding to the flaky list to investigate

This PR is to resolve a different flaky issue so I'll merge

ktoso commented 1 year ago

Minor follow up ticket https://github.com/apple/swift-distributed-actors/issues/1129

ktoso commented 1 year ago

I'll merge so we have less flaky tests but please do review when you're back from break @yim-lee !