apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors
https://apple.github.io/swift-distributed-actors/
Apache License 2.0
580 stars 54 forks source link

=lifecycle missing synchronization; those methods may be invoked from outside actor #1135

Closed ktoso closed 11 months ago

ktoso commented 11 months ago

These methods may be invoked from outside the actor, so synchronize them properly as the rest of the container.

I need to review some more code for safety and we should get a tsan build going here, we missed this for quite a while huh.

rdar://112815057

ktoso commented 11 months ago

One failure, flaky test need to revisit https://github.com/apple/swift-distributed-actors/issues/1034