SWIM: Unlock ignored_test_swim_shouldNotifyClusterAboutUnreachableNode_andThenReachableAgain

apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors

https://apple.github.io/swift-distributed-actors/

Apache License 2.0

584 stars 54 forks source link

SWIM: Unlock ignored_test_swim_shouldNotifyClusterAboutUnreachableNode_andThenReachableAgain #405

Open ktoso opened 4 years ago

ktoso commented 4 years ago

I was unable to get the following test nice and reproducable so we now have an integration test with suspending the entire system to cover it.

Would be nice to revive:

    // FIXME: Can't seem to implement a hardened test like this...
     func ignored_test_swim_shouldNotifyClusterAboutUnreachableNode_andThenReachableAgain() throws {

Introduced in https://github.com/apple/swift-distributed-actors/pull/403/files?file-filters%5B%5D=.swift#diff-d008a60d3a0938d1713ab1369bd05b86R218-R262

ktoso commented 4 years ago

Revisit this as we extract it into its own repo; This will make it also easier to test I hope