Special handle localhost/127.0.0.1 in handshakes?

apple / swift-distributed-actors

Peer-to-peer cluster implementation for Swift Distributed Actors

Apache License 2.0

597 stars 56 forks source link

Open ktoso opened 4 years ago

ktoso commented 4 years ago

When we get handshakes we compare the string of the passed in host i.e. "localhost" to what we bound to.

If we bound to 127.0.0.1 but someone tries to handshake with localhost, we'd reject this (!).

Ideas

perhaps we should resolve the incoming hostname before comparing it with the host we bound to?
perhaps special treating localhost and its IPv4 and IPv6 representations in handshakes?

ktoso commented 4 years ago