Closed fabianfett closed 1 year ago
Thanks for catching this -- here I think indeed we'll be able to do that 👀 Let's give it a shot.
I'm not sure about this, it means we'd lose the ability to:
span.attributes["http.status"] = response.status
which is very nice 🤔 I could not find a way around it.
We can add additional API though, I'll do that
Currently
SpanAttributes
uses an existential for its subscript API.Swift Logging uses the concrete type
Logger.Metadata.Value
instead:I think that we should change the SpanAttributes subscript API to return a
SpanAttribute
. This way this would work like Logging and we remove an existential from the API boundary