apple / swift-log

A Logging API for Swift
https://apple.github.io/swift-log/
Apache License 2.0
3.53k stars 294 forks source link

visionOS Compatibility #284

Closed zarghol closed 11 months ago

zarghol commented 11 months ago

Expected behavior

The package should build with a visionOS target

Actual behavior

Some compiler errors are produced, due to some missing #if os()

Steps to reproduce

  1. Open the package with Xcode 15 beta 3
  2. Target a visionOS device (simulator for now)
  3. Try to build

If possible, minimal yet complete reproducer code (or URL to code)

just swift-log code

SwiftLog version/commit hash

Tested with version 1.5.3

Swift & OS version (output of swift --version && uname -a)

swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1) Darwin 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

zarghol commented 11 months ago

Already working thanks to commit 5996c7a. Not sure why I didn't have this fix in my dependencies