search

apple / swift-log

A Logging API for Swift
https://apple.github.io/swift-log/
Apache License 2.0
3.48k stars 284 forks source link

Drop Swift versions earlier than 5.8 #299

Closed gjcairo closed 4 months ago

gjcairo commented 4 months ago

This PR removes support for Swift versions earlier than 5.8

Motivation:

Following the changes done in swift-metrics on https://github.com/apple/swift-metrics/pull/141, I believe we should align swift-log with the rest of the ecosystem too and support only the last 3 Swift releases.

Modifications:

This PR removes support for Swift versions earlier than 5.8

Result:

Only the last 3 Swift releases are now supported.

ktoso commented 4 months ago

@swift-server-bot test this please

ktoso commented 4 months ago

Mind checking the soundness (formatting issue)? The CI jobs for old swift we'll remove.

FranzBusch commented 4 months ago

I think the soudness job just needs to be updated to use a newer docker file

gjcairo commented 4 months ago

No, there was an actual whitespace formatting issue - just fixed it. The pipeline for api breakage has to be updated to use a newer docker image though. I've asked @yim-lee to take care of the CI changes.

yim-lee commented 4 months ago

CI updated. @swift-server-bot test this please.

gjcairo commented 4 months ago

@swift-server-bot test this please

gjcairo commented 4 months ago

Well, I don't think that worked :D @ktoso / @yim-lee mind triggering the tests again?

FranzBusch commented 4 months ago

@swift-server-bot test this please

FranzBusch commented 4 months ago

@swift-server-bot add to allowlist

FranzBusch commented 4 months ago

@gjcairo We gotta update the breaking change checker script the same way we did in metrics.

ktoso commented 4 months ago

branch protection rules adjusted in github -- can you fix the api checker?