search

apple / swift-metrics

Metrics API for Swift
https://apple.github.io/swift-metrics/
Apache License 2.0
645 stars 59 forks source link

Use the MetricsTestKit in the MetricsTests rather than using a copy of the TestMetrics utilities #128

Closed hamzahrmalik closed 1 year ago

hamzahrmalik commented 1 year ago

Use the MetricsTestKit in the MetricsTests rather than using a copy of the TestMetrics utilities

Motivation:

Currently we have a copy of TestMetrics within the test target, which is entirely redundant

Modifications:

Make the test target rely on the existing MetricsTestKit target. Expand the functionality of MetricsTestKit to fill gaps needed for these existing tests

Result:

We lose the copy, and we exercise the public MetricsTestKit which gives us some confidence that it works