search

apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
465 stars 82 forks source link

decide if we want to support Swift 4.0 for HTTP2 #17

Closed weissi closed 6 years ago

weissi commented 6 years ago

Current situation

Possible fixes:

paging @normanmaurer , @AlanQuatermain , @Lukasa , @ianpartridge, @pushkarnk, @tanner0101, @0xTim

ianpartridge commented 6 years ago

It depends on what it would take to support 4.0. If it's easy, then why not support it?

If it's difficult or involves some compromises, then it's probably better not to support it.

normanmaurer commented 6 years ago

👍

Am 30.08.2018 um 17:41 schrieb Ian Partridge notifications@github.com:

It depends on what it would take to support 4.0. If it's easy, then why not support it?

If it's difficult or involves some compromises, then it's probably better not to support it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

AlanQuatermain commented 6 years ago

I’d be quite happy for the project to require latest-minor-release of its target Swift version. Given the larger nature of the changes in Swift 4.2 I’m prepared to accept 4.1 as the baseline, but I’d prefer to go with 4.2 as soon as it’s officially available.

Sent from my iPhone

On Aug 30, 2018, at 9:22 AM, Norman Maurer notifications@github.com wrote:

👍

Am 30.08.2018 um 17:41 schrieb Ian Partridge notifications@github.com:

It depends on what it would take to support 4.0. If it's easy, then why not support it?

If it's difficult or involves some compromises, then it's probably better not to support it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

tanner0101 commented 6 years ago

officially don't support Swift 4.0

This option is fine by me. Vapor 3 requires >= 4.1. Vapor 4 will likely require >= 5.

MrMage commented 6 years ago

I would definitely be in favor of requiring Swift 4.1 or even 4.2.

weissi commented 6 years ago

thanks everybody, Swift 4.0 is a pain so I proposed a PR to make it officially 4.1 only. We can't go 4.2-only just yet because 4.2 isn't released yet and also Vapor/Kitura require running on 4.1.

weissi commented 6 years ago

(but letting @Lukasa approve the PR in case he has information that I don't)