search

apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
462 stars 82 forks source link

Failed assertion in change from 1.24.1 to 1.25.0 #375

Closed pardeike closed 1 year ago

pardeike commented 1 year ago

We experience an assertion failure in our gRPC client in this assertion:

https://github.com/apple/swift-nio-http2/compare/1.24.1...1.25.0#diff-cf9025d8ea6d311afe1a3ad83fd8c3456c162d86fde91c690e081490f0ec99f3R841

We use grpc-swift 1.14.1

Lukasa commented 1 year ago

Can you provide the text of that assertion please?

Lukasa commented 1 year ago

Additionally, can you provide a call stack?

pardeike commented 1 year ago

The problem appears in our app we deploy in production of the Swedish Police. So no, right now I cannot give you more details. The problem appeared a few days ago for the first time (grpc-swift unfortunately uses “from:” and it’s a sporadic problem.

Our tester has produced it once and now that I know you’re interested I can ask him to reproduce and get what you asked for. I do have these screenshots I am allowed to share. Sorry for the limiting crop:

5E5E1D85-5175-4D84-9B83-5659C950D2EA 119BB197-9A24-4E3C-A89E-F0192D960934

Lukasa commented 1 year ago

I'll take a look. Separately, if this is crashing in production I'm a bit worried: the assert in question should not crash in a release build but should produce a runtime error. Is there a reason your production app isn't being shipped in release mode?

Lukasa commented 1 year ago

Fixed in 1.25.2.