search

apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
462 stars 82 forks source link

Remove NIOHTTP2StreamDelegate Sendable requirement #384

Closed rnro closed 1 year ago

rnro commented 1 year ago

Motivation:

Remove NIOHTTP2StreamDelegate Sendable conformance requirement. This wasn't needed in the first place because NIOHTTP2Handler is not Sendable, therefore it never leaves the thread on which it is created.

The delegate may still be Sendable depending on the implementation but it is not a strict requirement.

Modifications:

Remove NIOHTTP2StreamDelegate Sendable requirement

Result:

Sendable is no longer required for NIOHTTP2StreamDelegate conformance

rnro commented 1 year ago

API breakage is expected and is okay because we haven't cut a release since this API was added.

Lukasa commented 1 year ago

Merging over CI failure.