search

apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
462 stars 82 forks source link

Replace os() with canImport(Darwin) #399

Closed o-nnerb closed 1 year ago

o-nnerb commented 1 year ago

This will enable compiling the package to xrOS using the right code.

Lukasa commented 1 year ago

@swift-server-bot add to allowlist

FranzBusch commented 1 year ago

@swift-server-bot test this please

o-nnerb commented 1 year ago

@FranzBusch is this test failure related to the modification I've made?

I was unable to relate the CI output with the changes applied here.

FranzBusch commented 1 year ago

No this looks like our allocation counters need to be updated because we regressed somewhere. We should check where that allocation regression comes from.

Lukasa commented 1 year ago

Alloc limits fix in #400

o-nnerb commented 1 year ago

@Lukasa great catch! You nailed it.

To be clear: I'm referring the #if removal suggestion and the alloc fixes haha.