search

apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
462 stars 82 forks source link

H2 stream AsyncIterator non-sendable on 5.7 #405

Closed rnro closed 1 year ago

rnro commented 1 year ago

Motivation:

Marking NIOHTTP2InboundStreamChannels.AsyncIterator as non-sendable fails to compile on 5.6 however implicitly non-sendable will do, this is a nice-to-have.

Modifications:

Move the non-sendable annotation to only apply >= 5.7

Result:

NIOHTTP2InboundStreamChannels.AsyncIterator is implicitly non-sendable on 5.6

rnro commented 1 year ago

API breakage checker is wrong

09:52:59 1 breaking change detected in NIOHTTP2:
09:52:59   💔 API breakage: struct NIOHTTP2InboundStreamChannels.AsyncIterator has removed conformance to Sendable