apple / swift-nio-http2

HTTP/2 support for SwiftNIO
https://swiftpackageindex.com/apple/swift-nio-http2/main/documentation/niohttp2
Apache License 2.0
462 stars 82 forks source link

Accept PING frames even when fully quiesced #455

Closed clintonpi closed 3 weeks ago

clintonpi commented 1 month ago

Motivation:

When the connection is fully quiesced, an endpoint responds with a connection error when it receives or tries to respond to a PING frame. This behaviour is unnecessary.

Modifications:

Result:

When the connection is fully quiesced, an endpoint will treat receipt and sending of a PING frame as it would when the connection is active.

clintonpi commented 1 month ago

Oops. Yes, of course.

Lukasa commented 3 weeks ago

@swift-server-bot test this please