Separate public/private keys and signatures into protocol conformances

apple / swift-nio-ssh

SwiftNIO SSH is a programmatic implementation of SSH using SwiftNIO

Apache License 2.0

398 stars 49 forks source link

Separate public/private keys and signatures into protocol conformances #158

Open Joannis opened 1 year ago

Joannis commented 1 year ago

As it stands, all the supported public/private key implementations are deeply integrated with NIOSSH through the internal enums that NIOSSH relies on. This PR moves that responsibility into a protocol conformance, paving the way towards custom public/private key types - and therefore moving towards supporting older/insecure standards such as RSA.

Joannis commented 1 year ago

As it's currently intended, this PR is regarded a precursor to a PR that allows users to register their own public/private key types. I intend to follow up with that shortly.

tkrajacic commented 3 months ago

Is there anything blocking this? I'd love to have this 😀