search

apple / swift-nio-ssl

TLS Support for SwiftNIO, based on BoringSSL.
https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl
Apache License 2.0
388 stars 139 forks source link

Fix non-modular header compile error #376

Closed makleso6 closed 2 years ago

makleso6 commented 2 years ago

I am using vapor and there is error when compiling swift-nio-ssl

Include of non-modular header inside framework module 'CNIOBoringSSL.CNIOBoringSSL_bn': '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/clang/include/inttypes.h'

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

makleso6 commented 2 years ago

same issue

https://github.com/AFNetworking/AFNetworking/issues/2205

makleso6 commented 2 years ago

Thanks for reply! I'll try to add patch in my project.

makleso6 commented 2 years ago

@glbrntt how can I apply patch

glbrntt commented 2 years ago

Ah, sorry I meant that the patch needs to be updated and applied by running the script to update the version of BoringSSL used by NIOSSL, we'll then tag a new release of NIOSSL. You don't need to apply the patch to your project.

glbrntt commented 2 years ago

@makleso6 how are you building this? I don't get an error when compiling so I want to make sure we actually fix this.

makleso6 commented 2 years ago

@glbrntt https://github.com/tuist/tuist/issues/4582 I am using Tuist to generate project and fetch dependencies. when compile project there is error.

makleso6 commented 2 years ago

@glbrntt You can reproduce by swift package generate-xcodeproj and build project

glbrntt commented 2 years ago

Thanks @makleso6 -- this should be fixed by https://github.com/apple/swift-nio-ssl/pull/378 and we'll get a release tagged soon after.

makleso6 commented 2 years ago

Thanks @glbrntt. Great!