apple / swift-nio-ssl

TLS Support for SwiftNIO, based on BoringSSL.

https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl

Apache License 2.0

388 stars 139 forks source link

Store internal error file and line number information in error wrappers #393

Closed wrinkl3 closed 2 years ago

wrinkl3 commented 2 years ago

Motivation

When generating errors, we want Error wrapper objects to store the file and the line number that the error originated from. This will greatly simplify debugging of the runtime failures.

Modification

Extended BoringSSLInternalError to store file path and line number along with the BoringSSL error code.
Extended errorMessage to append filepath:line to the message string
Now calling CNIOBoringSSL_ERR_get_error_line instead of CNIOBoringSSL_ERR_get_error to extract the necessary info

Result

Printing a BoringSSL error now shows the file path and the line number

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

Lukasa commented 2 years ago

@swift-nio-bot add to allowlist