apple / swift-nio-transport-services

Extensions for SwiftNIO to support Apple platforms as first-class citizens.
https://swiftpackageindex.com/apple/swift-nio-transport-services/main/documentation/niotransportservices
Apache License 2.0
282 stars 71 forks source link

Fix the syncOptions on most channels #202

Closed Lukasa closed 4 months ago

Lukasa commented 4 months ago

Motivation:

Looks like when we previously added syncOptions support to our channels, we had a few issues. The listeners had code added, but the code never worked. This is because the code was defined in subclasses, but the protocol conformance comes from the parent class, and that parent class did not have a customized protocol witness.

The datagram channel was also entirely missing its support.

Modifications:

Result:

Sync options actually work across the board.