apple / swift-nio

Event-driven network application framework for high performance protocol servers & clients, non-blocking.
https://swiftpackageindex.com/apple/swift-nio/documentation
Apache License 2.0
8k stars 652 forks source link

Swift Build warnings in 4.1 #228

Closed 0xTim closed 6 years ago

0xTim commented 6 years ago

Expected behavior

Build to complete successfully without any warnings

Actual behavior

App/.build/checkouts/swift-nio.git-3108475404973543938/Sources/NIO/System.swift:60:112: warning: using '!' in this location is deprecated and will be removed in a future release; consider changing this to '?' instead
private let sysInet_ntop: @convention(c) (CInt, UnsafeRawPointer?, UnsafeMutablePointer<CChar>?, socklen_t) -> UnsafePointer<CChar>! = inet_ntop
                                                                                                               ^                   ~
                                                                                                                                   ?

Steps to reproduce

  1. Build NIO in Xcode 9.3 Beta 4

SwiftNIO version/commit hash

1.3.0

Swift & OS version (output of swift --version && uname -a)

$  swift --version && uname -a
Apple Swift version 4.1 (swiftlang-902.0.43 clang-902.0.37.1)
Target: x86_64-apple-darwin17.4.0
Darwin Tims-MBP.home 17.4.0 Darwin Kernel Version 17.4.0: Sun Dec 17 09:19:54 PST 2017; root:xnu-4570.41.2~1/RELEASE_X86_64 x86_64
Lukasa commented 6 years ago

Well that looks silly. Want to open a PR for it?

0xTim commented 6 years ago

Will do