search

apple / swift-nio

Event-driven network application framework for high performance protocol servers & clients, non-blocking.
https://swiftpackageindex.com/apple/swift-nio/documentation
Apache License 2.0
7.85k stars 633 forks source link

testSimpleMPTCP should not fail for ENOPROTOOPT #2725

Closed rnro closed 1 month ago

rnro commented 1 month ago

Motivation:

MPTCP implementations are permitted to return ENOPROTOOPT if MPTCP has been disabled. This should not report as a test failure.

Source: https://www.mptcp.dev/implementation.html

Modifications:

Instead of failing the test, log the permitted error and return.

Result:

No more misleading testSimpleMPTCP test failures

rnro commented 1 month ago

I think you got the conditional a bit screwy here.

Don't code and dash kids. It was very screwy. I have amended it and run all NIO tests locally in a Swift 5.10 Docker container.

rnro commented 1 month ago

@swift-server-bot test this please