Issue-2734 - Clamp buffer to maximum upon large write operation

apple / swift-nio

Event-driven network application framework for high performance protocol servers & clients, non-blocking.

Apache License 2.0

7.94k stars 645 forks source link

Closed ali-ahsan-ali closed 2 weeks ago

ali-ahsan-ali commented 3 months ago

Fix Issue 2734 by clamping storage size after large write operation

Fix Issue 2734

Added a function to clamp storage by copying bytes and setting new capacity of storage
Adding a function to clamp the capacity of ByteBuffer
Added the ability to specify he maxBufferCapacity to MessageToByteHandler
Result:

Once a write message that is larger than the capacity of the MessageToByteHandler's maxBufferCapacity, it clamps the byteBuffer down.

ali-ahsan-ali commented 3 months ago

ali-ahsan-ali commented 3 weeks ago

Hey @weissi LMK when you find time to take a look at this. No rush!

weissi commented 3 weeks ago

Hey @weissi LMK when you find time to take a look at this. No rush!

Commented, looks 99% complete, just three small things

ali-ahsan-ali commented 2 weeks ago

Will cry tears of joy once this gets merged 👍