search

apple / swift-numerics

Advanced mathematical types and functions for Swift
Apache License 2.0
1.66k stars 140 forks source link

Update license headers and copyright notices #282

Closed markuswntr closed 3 months ago

markuswntr commented 4 months ago

There are a few slightly different versions of license headers distributed along the files of the projects, so I tried to unify them using the existing headers and the template from swift-collection (https://github.com/apple/swift-collections/commit/540348f1475110b307e6c59b394c70d1468da229) - and update the year of all copyright notices in the process.

NevinBR commented 3 months ago

Why are you trying to remove the word “Numerics” from the project name in the copyright notice?

markuswntr commented 3 months ago

It really is just a copy of the template used in related projects, e.g.:

Neither have the project name in the copyright notice, but only in the first line of the license header.

stephentyrone commented 3 months ago

The existing text was discussed with our lawyers chose when we set up the project, which somewhat predates most of the other packages (and hence some of the decisions made around them). Absent a need to change it, we'll keep it as-is.

If there's a specific concern that would merit reconsidering the text, I'm open to discussing that.

markuswntr commented 2 months ago

The existing text was discussed with our lawyers chose when we set up the project, which somewhat predates most of the other packages (and hence some of the decisions made around them).

Just to make sure this was not missed, because the PR description could have been clearer: The main goal of this PR was not to change the existing text. As of now, there are a few files in the project that do not have the license header that was chosen when you set up the project, but a slightly different one. The license header in Complex+ElementaryFunctions.swift, _TestSupport/Error.swift and others, for example, seems to be a copy from the license header template in apple/swift, while others contain a copy from the template in related projects. So I tried to fix the invalid ones and in doing so I chose the version that is used in the related projects I mentioned above.

If this is something that should be addressed, I can reopen the branch and update the files to match the text chosen at the project setup - but I am fine to leave the PR closed if this is not relevant.

stephentyrone commented 2 months ago

They appear to all be files that I authored completely (except for one where @NevinBR modified some comments), so I can simply fix that up.