search

apple / swift-openapi-generator

Generate Swift client and server code from an OpenAPI document.
https://swiftpackageindex.com/apple/swift-openapi-generator/documentation
Apache License 2.0
1.23k stars 89 forks source link

Update compat suite OpenAPI documents to their latest versions #418

Closed czechboy0 closed 5 months ago

czechboy0 commented 6 months ago

Motivation

Update the docs used by the compat suite, to be representative for 1.0.

Modifications

Updated to the latest versions of all docs.

Result

Using the latest versions.

Test Plan

CI passed (both generation and building), and locally I ran both GitHubs, as they don't build in CI even in the full pipeline.

czechboy0 commented 6 months ago

@swift-server-bot compat-test-full

simonjbeaumont commented 6 months ago

Looks like even the non-build compat test failed. 🥴

czechboy0 commented 6 months ago

Looks like even the non-build compat test failed. 🥴

Yup, I didn't actually run GitHub and GitHub Enterprise locally, I'll make the necessary fixes. Seems it's just the expected diagnostics changed.

czechboy0 commented 6 months ago

@swift-server-bot compat-test-full

czechboy0 commented 6 months ago

Ok I also ran and built both GitHub's locally (they're disabled in CI). All good.

czechboy0 commented 6 months ago

@simonjbeaumont the build timed out after 60min 😕

simonjbeaumont commented 6 months ago

@simonjbeaumont the build timed out after 60min 😕

Yep. It will do that. We could potentially filter GitHub before building and/or increase the timeout, given this job doesn't run on every PR.

We can also consider some suggestions in #253.

czechboy0 commented 6 months ago

We could potentially filter GitHub before building and/or increase the timeout, given this job doesn't run on every PR.

I don't think we build either GitHub in the full pipeline, so it's strange that it still timed out. Should I disable another large doc from building to get it through?

simonjbeaumont commented 6 months ago

Potentially we regressed our generation and/or compile times since we introduced this pipeline. Be curious to understand by how much, the numbers posted by the adopter on the other issue seem to suggest quite a bit.

czechboy0 commented 6 months ago

Didn't we also last test this on 5.8, and switched to 5.9 since?

czechboy0 commented 6 months ago

Yeah, last time this passed was in early October still on 5.8: https://ci.swiftserver.group/job/swift-openapi-generator-compatibility-test-full-prb/12/

simonjbeaumont commented 6 months ago

Probably worth getting this to run periodically.

So there's a few variables here:

czechboy0 commented 6 months ago

Yup I think all of our PR pipelines should also run nightly, as a baseline.